Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: responsive testconnection #2973

Merged
merged 5 commits into from
Feb 28, 2024
Merged

feat: responsive testconnection #2973

merged 5 commits into from
Feb 28, 2024

Conversation

pavanjoshi914
Copy link
Contributor

Describe the changes you have made in this PR

make test connection screen responsive and refactor headings

Link this PR to an issue [optional]

(Remove other not matching type)

  • feat: New feature (non-breaking change which adds functionality)

Screenshots of the changes [optional]

image

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the names of those fields are not necessary at this point. A user doesn't know what an "alias" is, anyway.

@pavanjoshi914
Copy link
Contributor Author

will this work?
image

@pavanjoshi914
Copy link
Contributor Author

the only motive here is to split alias and account name as it's too long for smaller screens as it was inline before

@reneaaron
Copy link
Contributor

I don't understand. The account name & alias have always been separated by a dash, right?

image

@pavanjoshi914
Copy link
Contributor Author

pavanjoshi914 commented Feb 1, 2024

yup but on smaller screens it looks something like this. and the account names are mostly continuous strings. so instead of breaking words or hiding overflows on one long string, I wished to separate both on a new line and then add additional break-word to them separately if needed
image

@reneaaron reneaaron added the next-release To be included in the next release label Feb 8, 2024
@reneaaron reneaaron enabled auto-merge (squash) February 27, 2024 11:56
@pavanjoshi914 pavanjoshi914 merged commit 47a45bf into master Feb 28, 2024
6 checks passed
@pavanjoshi914 pavanjoshi914 deleted the test-connection branch February 28, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release To be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants