fix: use browser router in http mode #1009
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
commented
Jan 18, 2025
| @@ -61,20 +61,24 @@ function AppCreatedInternal() { | |||
| } | |||
| // dispatch a success event which can be listened to by the opener or by the app that embedded the webview | |||
| // this gives those apps the chance to know the user has enabled the connection | |||
| const nwcEvent = new CustomEvent("nwc:success", { detail: {} }); | |||
| const nwcEvent = new CustomEvent("nwc:success", { | |||
There was a problem hiding this comment.
do we actually consume this custom event anywhere?
I know window.opener.postMessage is consumed by Alby JS SDK. Do we need both?
There was a problem hiding this comment.
Ah, maybe this one is for a native app (I need to test it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #328
The deeplink flow does not work well with a hash router, this will likely break for developers who try to implement it and inject query parameters to configure the new app connection.
We might need to update a few guides, etc. For now I added a redirect to ensure old links still work.