Fix join clause on hourly_spend #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandobrito
requested a deployment
to
Approve Integration Tests
GitHub Actions
Waiting
NiallRees
approved these changes
Feb 11, 2025
fernandobrito
deployed
to
Approve Integration Tests
GitHub Actions
Active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent PR #173 introduced a new CTE on
hourly_spendto fetch the spend from several services frommetering_historyand it also removed a few existing CTEs that would be covered by the new CTE.The new CTE, however, lacked a clause on a JOIN, which caused the JOIN to fan out on cases when there are multiple rows in
daily_ratesfor the same service (eg: for theAUTOMATIC_CLUSTERINGservice, there could be 2 rows withusage_type = 'automatic clustering'andusage_type = 'adjustment-automatic clustering').This means that the previous release (5.4.0) caused
hourly_spendto overreport spend for such services covered by the CTE.This PR restores the extra clause on the JOIN that was present before to prevent this fan out.