More cleanups

gerstrong · Dec 17, 2023 · a721600 · a721600
1 parent 8450c33
commit a721600
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/src/filtertransdialog.cpp b/src/filtertransdialog.cpp
@@ -2151,7 +2151,7 @@ void mmFilterTransactionsDialog::OnChoice(wxCommandEvent& event)
     }
 }
 
-void mmFilterTransactionsDialog::OnMenuSelected(wxCommandEvent& event)
+void mmFilterTransactionsDialog::OnMenuSelected(wxCommandEvent&)
 {
     m_color_value = colorButton_->GetColorId();
     if (!m_color_value)

diff --git a/src/filtertransdialog.h b/src/filtertransdialog.h
@@ -159,7 +159,7 @@ class mmFilterTransactionsDialog: public wxDialog
     void OnShowColumnsButton(wxCommandEvent& /*event*/);
     void OnMoreFields(wxCommandEvent& event);
     void OnChoice(wxCommandEvent& event);
-    void OnMenuSelected(wxCommandEvent& event);
+    void OnMenuSelected(wxCommandEvent&);
     void OnQuit(wxCloseEvent& event);
 
 private:

diff --git a/src/mmcheckingpanel.cpp b/src/mmcheckingpanel.cpp
@@ -64,11 +64,9 @@ wxEND_EVENT_TABLE()
 //----------------------------------------------------------------------------
 
 mmCheckingPanel::mmCheckingPanel(wxWindow *parent, mmGUIFrame *frame, int accountID, int id)
-    : m_listCtrlAccount()
-    , m_AccountID(accountID)
+    : m_AccountID(accountID)
     , isAllAccounts_((-1 == accountID) ? true : false)
     , isTrash_((-2 == accountID) ? true : false)
-    , m_trans_filter_dlg(nullptr)
     , m_frame(frame)
 {
     Create(parent, id);
@@ -183,7 +181,7 @@ void mmCheckingPanel::filterTable()
             int txnMatch = m_trans_filter_dlg->mmIsRecordMatches(tran, splits);
             if (!txnMatch)
                 continue;
-            else expandSplits = txnMatch < full_tran.m_splits.size() + 1;
+            else expandSplits = txnMatch < static_cast<int>(full_tran.m_splits.size()) + 1;
         }
         else
         {
@@ -820,11 +818,9 @@ void mmCheckingPanel::initFilterSettings()
     }
 
     if (j_doc.HasMember("FILTER")) {
-        Value::MemberIterator v_name = j_doc.FindMember("FILTER");
         j_doc["FILTER"].SetString(item.mb_str(), j_doc.GetAllocator());
     }
-    else
-    {
+    else {
         auto& allocator = j_doc.GetAllocator();
         rapidjson::Value value(item.mb_str(), allocator);
         j_doc.AddMember("FILTER", value, allocator);