More warning cleanups

gerstrong · Jul 21, 2024 · 9348620 · 9348620
1 parent 8eadc80
commit 9348620
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 17 deletions.
diff --git a/src/optiondialog.cpp b/src/optiondialog.cpp
@@ -37,7 +37,7 @@ static const char * const s_pagetitle[] = {
     wxTRANSLATE("General"), wxTRANSLATE("View"), wxTRANSLATE("Dashboard"), wxTRANSLATE("Attachments"), wxTRANSLATE("Network"), wxTRANSLATE("Other")
 };
 
-wxIMPLEMENT_DYNAMIC_CLASS(mmOptionsDialog, wxDialog);
+wxIMPLEMENT_DYNAMIC_CLASS(mmOptionsDialog, wxDialog)
 
 wxBEGIN_EVENT_TABLE( mmOptionsDialog, wxDialog )
 EVT_BUTTON(wxID_OK, mmOptionsDialog::OnOk)
@@ -139,7 +139,7 @@ void mmOptionsDialog::CreateControls()
     /**********************************************************************************************
     Add the panels to the notebook
     **********************************************************************************************/
-    for (int i = 0; i < m_panel_list.size(); i++) {
+    for (unsigned int i = 0; i < m_panel_list.size(); i++) {
         m_listbook->InsertPage(i, m_panel_list.at(i), wxGetTranslation(s_pagetitle[i]), i ? false : true, i);
     }
 

diff --git a/src/optionsettingsview.cpp b/src/optionsettingsview.cpp
@@ -377,7 +377,7 @@ void OptionSettingsView::OnNavTreeColorChanged(wxCommandEvent& event)
     }
 }
 
-void OptionSettingsView::OnThemeManagerSelected(wxCommandEvent& event)
+void OptionSettingsView::OnThemeManagerSelected(wxCommandEvent&)
 {
     mmThemesDialog dlg(this);
     dlg.ShowModal();

diff --git a/src/optionsettingsview.h b/src/optionsettingsview.h
@@ -46,7 +46,7 @@ class OptionSettingsView : public OptionSettingsBase
 private:
     void Create();
     void OnHTMLScaleSpin(wxSpinEvent& event);
-    void OnThemeManagerSelected(wxCommandEvent& event);
+    void OnThemeManagerSelected(wxCommandEvent&);
     void OnNavTreeColorChanged(wxCommandEvent& event);
 
 private:

diff --git a/src/themes.cpp b/src/themes.cpp
@@ -52,7 +52,7 @@ bool mmThemesDialog::vfsThemeImageLoaded = false;
 mmThemesDialog::ThemeEntry mmThemesDialog::getThemeEntry(const wxString& name)
 {
     ThemeEntry thisTheme;
-    for (const auto theme : m_themes)
+    for (const auto &theme : m_themes)
     {
         if (theme.name == name)
         {
@@ -209,7 +209,7 @@ void mmThemesDialog::ReadThemes()
     addThemes(mmex::getPathUser(mmex::USERTHEMEDIR), false);
 
     m_themesListBox_->Clear();
-    for (const auto theme : m_themes)
+    for (const auto &theme : m_themes)
         m_themesListBox_->Append(theme.name);
     m_themesListBox_->SetStringSelection(Model_Setting::instance().Theme());
     m_themesListBox_->Refresh();
@@ -275,12 +275,12 @@ void mmThemesDialog::RefreshView()
     m_useButton->Enable(!thisTheme.isChosen);
 }
 
-void mmThemesDialog::OnThemeView(wxCommandEvent& event)
+void mmThemesDialog::OnThemeView(wxCommandEvent&)
 {
     RefreshView();
 }
 
-void mmThemesDialog::OnImport(wxCommandEvent& event)
+void mmThemesDialog::OnImport(wxCommandEvent&)
 {
     wxString fileName = wxFileSelector(_("Choose theme file to import")
         , wxEmptyString, wxEmptyString, wxEmptyString
@@ -321,7 +321,7 @@ void mmThemesDialog::OnImport(wxCommandEvent& event)
 
 }
 
-void mmThemesDialog::OnDelete(wxCommandEvent& event)
+void mmThemesDialog::OnDelete(wxCommandEvent&)
 {
     ThemeEntry thisTheme = getThemeEntry(m_themesListBox_->GetString(m_themesListBox_->GetSelection()));
     wxString deletingThemeText = _("Are you sure you want to delete this theme? If you want to use it again you will need to re-import it.");
@@ -340,7 +340,7 @@ void mmThemesDialog::OnDelete(wxCommandEvent& event)
 
 }
 
-void mmThemesDialog::OnUse(wxCommandEvent& event)
+void mmThemesDialog::OnUse(wxCommandEvent&)
 {
     ThemeEntry thisTheme = getThemeEntry(m_themesListBox_->GetString(m_themesListBox_->GetSelection()));
     wxString changingThemeText = _("Are you sure you want to use this theme? Please note that this will only take effect when MMEX is re-started.");
@@ -355,7 +355,7 @@ void mmThemesDialog::OnUse(wxCommandEvent& event)
     RefreshView();
 }
 
-void mmThemesDialog::OnOk(wxCommandEvent& event)
+void mmThemesDialog::OnOk(wxCommandEvent&)
 {
     EndModal(wxID_OK);
 }

diff --git a/src/themes.h b/src/themes.h
@@ -55,7 +55,7 @@ class mmThemesDialog : public wxDialog
     wxButton* m_okButton = nullptr;
 
 private:
-    mmThemesDialog() {};
+    mmThemesDialog() {}
 
     void Create(wxWindow* parent, const wxString &name);
     void CreateControls();
@@ -64,12 +64,12 @@ class mmThemesDialog : public wxDialog
     void addThemes(const wxString& themeDir, bool isSystem);
     ThemeEntry getThemeEntry(const wxString& name);
 
-    void OnOk(wxCommandEvent& event);
-    void OnImport(wxCommandEvent& event);
+    void OnOk(wxCommandEvent&);
+    void OnImport(wxCommandEvent&);
     void OnDelete(wxCommandEvent& event);
-    void OnUse(wxCommandEvent& event);
+    void OnUse(wxCommandEvent&);
     void OnHtmlLink(wxHtmlLinkEvent& event);
-    void OnThemeView(wxCommandEvent& event);
+    void OnThemeView(wxCommandEvent&);
 
     enum
     {

diff --git a/src/transdialog.cpp b/src/transdialog.cpp
@@ -1226,7 +1226,7 @@ void mmTransDialog::OnOk(wxCommandEvent& WXUNUSED(event))
     // Save split tags
     const wxString& splitRefType = Model_Attachment::reftype_desc(Model_Attachment::TRANSACTIONSPLIT);
 
-    for (int i = 0; i < m_local_splits.size(); i++)
+    for (unsigned int i = 0; i < m_local_splits.size(); i++)
     {
         Model_Taglink::Data_Set splitTaglinks;
         for (const auto& tagId : m_local_splits.at(i).TAGS)