Cleanups

gerstrong · Dec 2, 2023 · 687e182 · 687e182
1 parent 4b2e059
commit 687e182
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/stockdialog.h b/src/stockdialog.h
@@ -86,9 +86,10 @@ class mmStockDialog : public wxDialog
     wxListCtrl* m_price_listbox = nullptr;
 
     Model_Stock::Data* m_stock = nullptr;
-    bool m_edit;
-    int m_account_id;
     mmGUIFrame* m_gui_frame = nullptr;
+    bool m_edit = false;
+    int m_account_id = 0;
+
     enum
     {
         ID_DPC_STOCK_PDATE = wxID_HIGHEST + 800,

diff --git a/src/themes.cpp b/src/themes.cpp
@@ -52,7 +52,7 @@ bool mmThemesDialog::vfsThemeImageLoaded = false;
 mmThemesDialog::ThemeEntry mmThemesDialog::getThemeEntry(const wxString& name)
 {
     ThemeEntry thisTheme;
-    for (const auto theme : m_themes)
+    for (const auto &theme : m_themes)
     {
         if (theme.name == name)
         {

diff --git a/src/transactionsupdatedialog.cpp b/src/transactionsupdatedialog.cpp
@@ -80,7 +80,7 @@ transactionsUpdateDialog::transactionsUpdateDialog(wxWindow* parent
             m_hasNonTransfers = true;
     }
 
-    m_custom_fields = new mmCustomDataTransaction(this, NULL, ID_CUSTOMFIELDS);
+    m_custom_fields = new mmCustomDataTransaction(this, 0, ID_CUSTOMFIELDS);
 
     this->SetFont(parent->GetFont());
     Create(parent);
@@ -529,7 +529,7 @@ void transactionsUpdateDialog::SetPayeeTransferControls()
     }
 }
 
-void transactionsUpdateDialog::OnTransTypeChanged(wxCommandEvent& event)
+void transactionsUpdateDialog::OnTransTypeChanged([[maybe_unused]] wxCommandEvent& event)
 {
     SetPayeeTransferControls();
 }