Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Luxembourg stock exchange #446

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

w3stling
Copy link

Add Luxembourg stock exchange

Source:
https://www.luxse.com/trading/opening-hours-and-closing-days

  • Add calendar module exchange_calendars/exchange_calendar_{Exchange MIC}.py. Module should contain a subclass of the abstract base class ExchangeCalendar (in exchange_calendars/exchange_calendar.py).
    • Name subclass {Exchange MIC}ExchangeCalendar.
    • Override methods and properties as required, being guided by ExchangeCalendar documentation and in-code comments. All abstract properties must be overriden.
    • Include references / links for holidays and timings (either to class documentation or as comments).
  • Import calendar class to exchange_calendars/calendar_utils.py and add class to _default_calendar_factories.
  • Add calendar test module tests/test_{Exchange MIC}_calendar.py Module should contain a subclass of the test base class ExchangeCalendarTestBase (in tests/test_exchange_calendars.py).
    • Name subclass Test{Exchange MIC}Calendar.
    • Override fixtures as required, being guided by ExchangeCalendarTestBase documentation and in-code comments. The calendar_cls and max_session_hours fixtures must be overriden.
  • Add a .csv file containing expected timings to tests/resources/{Exchange MIC}.csv. This file be generated by executing python etc/make_exchange_calendar_test_csv.py {Exchange MIC}. See script's documentation.
  • Add new exchange to Calendars table of README.md.
  • PR it!

@maread99
Copy link
Collaborator

New exchange! Awesome, thanks @w3stling.

@maread99 maread99 added the enhancement New feature or request label Jan 14, 2025
@maread99 maread99 merged commit 1e54cb8 into gerrymanoim:master Jan 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants