Make installer to point sudo.exe symlink at Current directory
#391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IDisposable
commented
Feb 3, 2025
| @@ -30,9 +30,9 @@ | |||
|
|
|||
| <InstallExecuteSequence> | |||
| <!-- https://stackoverflow.com/a/17608049/97471 --> | |||
| <Custom Action="CreateSudoCurrentFolderLink" Before="InstallFinalize" Condition="NOT Installed" /> | |||
There was a problem hiding this comment.
Have to create the Current junction directory before we create the sudo.exe symlink.
IDisposable
commented
Feb 3, 2025
| @@ -112,12 +112,12 @@ | |||
| </Fragment> | |||
|
|
|||
| <Fragment> | |||
| <CustomAction Id="CreateSudoExeLink" Directory="VERSIONFOLDER" ExeCommand="cmd /c mklink sudo.exe "[VERSIONFOLDER]gsudo.exe"" Execute="deferred" Return="ignore" Impersonate="no" /> | |||
| <CustomAction Id="RemoveSudoExeLink" Directory="VERSIONFOLDER" ExeCommand="cmd /c DEL sudo.exe" Execute="deferred" Return="ignore" Impersonate="no" /> | |||
| <CustomAction Id="CreateSudoExeLink" Directory="VERSIONFOLDER" ExeCommand="cmd /c mklink sudo.exe "[INSTALLFOLDER]Current\gsudo.exe"" Execute="deferred" Return="ignore" Impersonate="no" /> | |||
There was a problem hiding this comment.
Point the sudo.exe symlink at the install folder's Current junction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the symlink point at the
Currentjunction directory instead of the specific installed folder.To do this, have to create the junction before the symlink (and upon uninstall do it in the opposite order).
Fixes #390