Adds methods for iterating and visiting #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build/dependencies/h5fortran/src/write.f90:95:132:
95 | if(any(iend - istart > ddims)) error stop 'ERROR:h5fortran:create: iend - istart > dset_dims' // dname // ' in ' // self%filename
| 1
Error: Line truncated at (1) [-Werror=line-truncation]
build/dependencies/h5fortran/src/write.f90:95:132:
95 | if(any(iend - istart > ddims)) error stop 'ERROR:h5fortran:create: iend - istart > dset_dims' // dname // ' in ' // self%filename
| 1
Error: ‘filena’ at (1) is not a member of the ‘hdf5_file’ structure; did you mean ‘filename’?
compilation terminated due to -fmax-errors=1.
f951: some warnings being treated as errors
<ERROR> Compilation failed for object " build_dependencies_h5fortran_src_write.f90.o "
<ERROR> stopping due to failed compilation
STOP 1
14NGiestas
changed the title
14NGiestas
changed the title
scivision
force-pushed
the
main
branch
2 times, most recently
from
f849e62 to
9a1e6ac
Compare
|
actually when implementing this, I found that it segfaults on GCC in Linux |
This comment was marked as outdated.
This comment was marked as outdated.
|
Ok, the problem was much simpler to solve: the variable |
|
However ci_windows and oneapi_linux are still failing, I'm working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
This pull request introduces new functionalities for iterating over and visiting datasets in HDF5 files, along with some minor fixes and improvements. The most important changes include the addition of
iterateandvisitprocedures, updates toCMakeLists.txtto accommodate new source files, and corrections to existing error messages.New functionalities:
iterateandvisitprocedures to theh5fortranmodule for iterating over and visiting datasets in HDF5 files. (src/interface.f90,src/iterate.f90,src/visit.f90) [1] [2] [3] [4]Build system updates:
CMakeLists.txtto include new source filesiterate.f90andvisit.f90. (src/CMakeLists.txt)Documentation updates:
iterateandvisitprocedures inAPI.md. (API.md)Minor fixes:
README.mdfrom "impementation" to "implementation". (README.md)utils.f90andwrite.f90. (src/utils.f90,src/write.f90) [1] [2] [3]Testing updates:
iterateandvisitprocedures inCMakeLists.txtfor tests. (test/CMakeLists.txt)