#9825: Add an config option to enable mapInfo highlight by default #9829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Description: - Adding an option called "identifyHighlight" to enable/disable mapInfo highlight by default in localConfig file - implement intiate highlight value based on the added option and the default is false - write unit tests based on change
6 tasks
* Description: - fix FE test failure by editing a unit test in identifyContainer that test calling initiateOrResetHighlight on close identify
MV88
requested changes
Dec 20, 2023
There was a problem hiding this comment.
it works, but please refactor this by reusing the INIT_PLUGIN action
generally when there is a cfg prop that needs to initialize the state and then change due to user actions we follow this approach
- only when plugin mounts (where connect is ) we call an onMount onInit action
- in the reducer we initialize the configuration
- we then user another action to change a specific prop value and a selector to fetch the value
Also please remember to avoid touching localConfig.json if not needed. undefined or null are falsy values as well, and it's better not not list props in cfg if not needed and use the default value associated to it at plugin level
* Description: - resolve review comments by using INIT_PLUGIN action instead of the new created one - Remove the new created action ' INIT_IDENTIFY_HIGHLIGHT' and its dependent code - Remove the added config from localConfig file
MV88
approved these changes
Jan 9, 2024
|
@ElenaGallo please test in DEV using a context and customizing the cfg of Identify plugin with "highlightEnabledFromTheStart": true |
tdipisa
added
the
BackportNeeded
|
@ElenaGallo let us know for the backport |
|
Test passed, @mahmoudadel54 please backport to 2023.02.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Jan 11, 2024
…t by default (geosolutions-it#9829) * geosolutions-it#9825: Add option to enable mapInfo highlight by default * Description: - Adding an option called "identifyHighlight" to enable/disable mapInfo highlight by default in localConfig file - implement intiate highlight value based on the added option and the default is false - write unit tests based on change * geosolutions-it#9825: Add option to enable mapInfo highlight by default * Description: - fix FE test failure by editing a unit test in identifyContainer that test calling initiateOrResetHighlight on close identify * geosolutions-it#9825: Add option to enable mapInfo highlight by default * Description: - resolve review comments by using INIT_PLUGIN action instead of the new created one - Remove the new created action ' INIT_IDENTIFY_HIGHLIGHT' and its dependent code - Remove the added config from localConfig file
Backport is done ---> #9871 |
MV88
pushed a commit
that referenced
this pull request
Jan 11, 2024
…9829) (#9871) * #9825: Add option to enable mapInfo highlight by default * Description: - Adding an option called "identifyHighlight" to enable/disable mapInfo highlight by default in localConfig file - implement intiate highlight value based on the added option and the default is false - write unit tests based on change * #9825: Add option to enable mapInfo highlight by default * Description: - fix FE test failure by editing a unit test in identifyContainer that test calling initiateOrResetHighlight on close identify * #9825: Add option to enable mapInfo highlight by default * Description: - resolve review comments by using INIT_PLUGIN action instead of the new created one - Remove the new created action ' INIT_IDENTIFY_HIGHLIGHT' and its dependent code - Remove the added config from localConfig file
ElenaGallo
removed
the
BackportNeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enables mapInfo highlight in identify by default if the option 'identifyHighlight' is added to config file.
The PR includes:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#9825
What is the current behavior?
#9825
What is the new behavior?
Now if the config option 'identifyHighlight' is defined by true, the mapInfo highlight in identify side bar will be active by default.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)