Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9627 replace quill editor with draftjs editor in dashboard text widget #9679

Conversation

mumairr
Copy link
Contributor

@mumairr mumairr commented Nov 2, 2023

Description

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
Fix #9627
Closed PR #9673
What is the new behavior?
Based on branch 2022.02.xx, Draftjs added, allows embedding of PDFs or any link, embedding allowed, image upload & font families is configurable via props

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

Previous pull request at #9673 was mistakingly closed. It is linked here for reference of comments.

taba90 and others added 30 commits August 3, 2022 16:45
…lugin (geosolutions-it#8504) (geosolutions-it#8510)

* geosolutions-it#7934 refactor to version plugin, moving it to About plugin
* update migration guideline

# Conflicts:
#	web/client/hooks/useModulePlugins.js
#	web/client/plugins/Version.jsx
#	web/client/product/plugins.js
…on in createproject.js script (geosolutions-it#8528)  (geosolutions-it#8549)

* geosolutions-it#8458 adding first commit creation in createproject.js script (geosolutions-it#8528)

* geosolutions-it#8458 adding first commit creation in createproject.js script

* clean up and improved checkout of branch only if present

* extended project doc with stable branch explanation

* geosolutions-it#8458 restore old release since it's not out yet (geosolutions-it#8546)
… so that muteState has all the epics listed correctly. (geosolutions-it#8514)

(cherry picked from commit 20ca575)
…geosolutions-it#8550)

* Properly resolve issue when internal PluginsContainer cause part of the plugins being muted on the same page. Relevant for context creator map viewer or any inline map viewers.

* Two new tests to make sure that epics will be muted whenever window.location.hash changes and won't be muted otherwise on subsequent plugins reloads (e.g. for nested plugin containers)

(cherry picked from commit ce960b4)
…n. (geosolutions-it#8544)

* geosolutions-it#8543 Make tutorial compatible with being module plugin.

- Improved REDUCERS_LOADED action to make it pass list of added reducers as a payload.
- Updated switchTutorialEpic to make it actually triggered once tutorial reducer is added & one of the subsequent actions dispatched.

* Rely only on router information from state. Plausibly because of the mute/unmute of the epics one of the LOCATION_CHANGE events is getting skipped, it makes inline stream gets incorrect information about current router in this case. Information from state is more reliable.

* Moving action creator into separate file, amending jsdoc

* Amended tests to use state value.

(cherry picked from commit 7567d12)
…-it#8553)

* geosolutions-it#8551 fix dashboard embedded crash error

* fix crash on observables for dashboard

(cherry picked from commit 91cc6bf)
…port-2022.02.xx-module-plugins

[Backport 2022.02.xx] module plugins PRs
…#8568)

* Extended documentation for module extensions.
Extended documentation for epics, describing how mute/unmute of the epic works.

* Link to chapter of documentation page;
Updated jsdoc to include StateUtils into documentation.

* Documentation update to make it clear when exactly plugins are loaded

* Update extensions.md

Co-authored-by: Tobia Di Pisa <[email protected]>
(cherry picked from commit a914848)
… context page (geosolutions-it#8565) (geosolutions-it#8569)

* geosolutions-it#8564 Reduce amount of plugins initially loaded on the context page before the actual context configuration of plugins become available.
Context page will check for the "context" object inside localConfig plugins configuration. It will load only "Context" and "FeedbackMask" plugins by default.

* Prevent viewer reload on context page. Amending tests

* Logic simplification

Co-authored-by: Lorenzo Natali <[email protected]>

* Missing comas

Co-authored-by: Lorenzo Natali <[email protected]>
(cherry picked from commit c2b4734)
…eosolutions-it#8572) (geosolutions-it#8577)

* Dynamic import of plugins - migration guideline

* Link to extensions transformation

(cherry picked from commit e847678)
allyoucanmap and others added 26 commits November 3, 2022 16:28
…selection on map click in 3D viewer (geosolutions-it#8750) (geosolutions-it#8770)

* geosolutions-it#8706 Restore multiple features selection on map click in 3D viewer (geosolutions-it#8750)

* restore multiple features selection on map click in 3D viewer

* add bring to front on default style for points

* increase timeout for failing test (geosolutions-it#8756)

* geosolutions-it#8757 Increase waitFor timeout in cesium map test (geosolutions-it#8771)

* add cesium simulate test utils
) (geosolutions-it#8865)

* Update data.en-US.json

* Update data.es-ES.json

* Update data.fr-FR.json

* Update data.de-DE.json

* Update web/client/translations/data.es-ES.json

Co-authored-by: stefano bovio <[email protected]>

* change clamp to ground translation based on symbolizer

Co-authored-by: stefano bovio <[email protected]>

Co-authored-by: Tobia Di Pisa <[email protected]>
@mumairr mumairr self-assigned this Nov 2, 2023
@mumairr mumairr closed this Nov 2, 2023
@mumairr mumairr deleted the Fix-#9627-Replace-Quill-editor-with-Draftjs-editor-in-Dashboard-Text-widget branch November 2, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Quill editor with Draftjs editor in Dashboard's Text widget