523 Further improvements for module plugins #8501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. This allows to pass full list of plugins to the nested PluginsContainer components
… it again from another plugin.
…ure that if at least one plugin intended to register epic and such plugin is on the page - epic will not be muted.
… map, context, dashboard, geostory.
…odule plugins are loaded at once.
…low changes: context creator page performs reset of context & load of new configuration once plugins are loaded. This happens after contextcreator\ContextCreator component was mounted and forces reset of tutorials list. Added check on componentDidUpdate resolves delayed reset issue.
…er state." This reverts commit 951a1cb.
…at all module plugins are loaded at once." This reverts commit 09fdf3f
…ad maps, map, context, dashboard, geostory." This reverts commit a1fb9eb.
… that load maps, map, context, dashboard, geostory."" This reverts commit c11a6ab.
… fact that all module plugins are loaded at once."" This reverts commit 3a54f0f.
…gin render state."" This reverts commit 2e0f9ae.
13 tasks
|
@tdipisa we used this branch implementation to test the application with all the plugin module and we did not noticed much difference in the final loading. For this reason we could keep some plugins static for the moment, maybe we could take this into account for future improvements (see #4675 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for further optimizations for module plugins. It's created on top of #8495 and includes all commits from that PR plus new changes.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information