Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4675: Improving MapStore Performances #6245

Merged

Conversation

allyoucanmap
Copy link
Contributor

Description

This PR introduces small improvements to the mapType HOC of BaseMap to import dynamically the map libraries. This work does not include all the needed fixes to align the Map plugin and BaseMap components in a single one but it should be integrated in the work started by @mbarto in this branch https://github.com/mbarto/MapStore2/tree/basemap_review.

Improvements:

  • dynamic load of map libraries inside BaseMap component (geostories, widgets, ...)
  • allow children as tools inside BaseMap component

The dynamic loading will split the map libraries from the main bundle and it should help to increase a bit the performance, in particular for custom project

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Feature

Issue

What is the current behavior?

#4675 small improvement for MS bundle

What is the new behavior?

see description

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other useful information

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 80.889% when pulling aa76e17 on allyoucanmap:base-map-dynamic-import into ac91678 on geosolutions-it:master.

@allyoucanmap allyoucanmap self-assigned this Nov 26, 2020
@allyoucanmap allyoucanmap merged commit f4b08c4 into geosolutions-it:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants