Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new data.pt-BR to full translation pt-BR #10759

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davicustodio
Copy link

@davicustodio davicustodio commented Jan 16, 2025

Description

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#10762

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@tdipisa
Copy link
Member

tdipisa commented Jan 17, 2025

@davicustodio thank you so much for contributing to MS. We will review asap.

Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contribution, in order to add a new language to the available ones in masptore you need to extend the framework codebase following instructions explained here: https://docs.mapstore.geosolutionsgroup.com/en/latest/developer-guide/internationalization/#how-to-add-a-new-language

If you have trouble in applying those changes let us know.

In order to test that this is working you can:

  • add pt-BR locale in the localConfig.json checking the previous paragraph
  • run mapstore locally
  • try to select the new locale in language selector

let me know if you need more help on this. In the meantime i've created this to keep track of this task #10762

Last but not least, i noticed that your version (3537) has many less lines than the English one (4197) so my suggestion would be to integrate missing lines and translate also those

@MV88 MV88 linked an issue Jan 17, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pt-BR new locale
3 participants