Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix displaying WMS layers from data.geopf.fr in 3d mode #10732

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

landryb
Copy link
Collaborator

@landryb landryb commented Dec 31, 2024

Description

https://data.geopf.fr/wms-r/wms & https://data.geopf.fr/wms-v/wms services only supports WMS 1.3.0. Cesium defaults to 1.1.1, so right now loading a layer from those services in 3d mode only results in 400 error codes. Pass the version from the options, and default to 1.1.1 if unset.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

#10592

What is the new behavior?

loading WMS layers in 3d mode from data.geopf.fr works.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

This might have the side effect of changing lots of WMS layers in existing 3d maps to now use WMS 1.3.0 ? At least it now allows me to load WMS layers from https://data.geopf.fr/wms-r/wms and https://data.geopf.fr/wms-v/wms.

Other useful information

…-it#10592)

data.geopf.fr only supports WMS 1.3.0. Cesium defaults to 1.1.1.
Pass the version from the options, and default to 1.1.1 if unset.
@landryb
Copy link
Collaborator Author

landryb commented Dec 31, 2024

i've blindly added tests, but havent been able to run them locally...

31 12 2024 14:31:25.435:INFO [karma-server]: Karma v6.4.0 server started at http://localhost:9876/
31 12 2024 14:31:25.435:INFO [launcher]: Launching browsers ChromeHeadless with concurrency unlimited
31 12 2024 14:31:25.444:INFO [launcher]: Starting browser ChromeHeadless
31 12 2024 14:32:25.482:WARN [launcher]: ChromeHeadless has not captured in 60000 ms, killing.
31 12 2024 14:32:25.627:INFO [launcher]: Trying to start ChromeHeadless again (1/2).
31 12 2024 14:33:25.685:WARN [launcher]: ChromeHeadless has not captured in 60000 ms, killing.
31 12 2024 14:33:25.752:INFO [launcher]: Trying to start ChromeHeadless again (2/2).
31 12 2024 14:34:25.815:WARN [launcher]: ChromeHeadless has not captured in 60000 ms, killing.
31 12 2024 14:34:25.894:ERROR [launcher]: ChromeHeadless failed 2 times (timeout). Giving up.

trusting GH actions to do it for me.

edit: my tests are green

2024-12-31T14:52:05.2464475Z ✔ wmsToCesiumOptions
2024-12-31T14:52:05.2476496Z ✔ wmsToCesiumOptions with version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant