Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog editor i18n #10571

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tha-nordiq
Copy link
Contributor

Description

Move url placeholders from hard coded values in MainFormUtils.js and MainForm.jsx to language files to allow i18n.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: i18n

Issue

What is the current behavior?
The url placeholders are always in english "e.g. https://mydomain.com/geoserver/wms"

What is the new behavior?
Now the url placeholders can be translated. Translations added for danish, german and spanish
"f.eks. https://mydomain.com/geoserver/wms"

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant