Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10530 fix catalog editor for array scenario #10531

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Sep 4, 2024

Description

fixing case when catalog url service is array, all details in issue

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

Fix #10530

What is the new behavior?

no crash in case of array

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@MV88 MV88 added this to the 2024.02.00 milestone Sep 4, 2024
@MV88 MV88 self-assigned this Sep 4, 2024
@tdipisa tdipisa requested review from offtherailz and removed request for allyoucanmap September 4, 2024 12:12
@tdipisa
Copy link
Member

tdipisa commented Sep 4, 2024

@MV88 there is a failing test which is not depending on this PR. @offtherailz will check it during review.

Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using the first URL, An error should be shown because the format with array is not supported, and so it is error prone.

Please show misconfiguration error.

@MV88
Copy link
Contributor Author

MV88 commented Sep 4, 2024

Instead of using the first URL, An error should be shown because the format with array is not supported, and so it is error prone.

Please show misconfiguration error.

done, please review again

Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The catalog still works for some reason in search, while gives error in the editor, as expected
even if not properly consistent, I think that it is enough for a misconfiguration, that by definition can have inconsistent results.

@offtherailz offtherailz merged commit 8956d9c into geosolutions-it:master Sep 6, 2024
6 checks passed
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 6, 2024
MV88 added a commit to MV88/MapStore2 that referenced this pull request Sep 6, 2024
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If a the url of service catalog is defined as array when you open it the application crash
3 participants