Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10473 support of autoDetectCORS for 3D tiles #10474

Closed

Conversation

offtherailz
Copy link
Member

@offtherailz offtherailz commented Jul 11, 2024

Description

This draft PR (missing tests and maybe need more options to discuss) is a work in progress and a proof of concept that tries to solve #10473.
In this PR I was able to check performances on 3D tiles now (that use CORS by default, when not specified in useCORS) and the implementation with autoDetectCORS.
Because of the results in terms of performances, I think we need to consider this or alternative solutions that use cors on 3D stuff (See other informations).

Things to do:

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

I tested this map

https://dev-mapstore.geosolutionsgroup.com/mapstore/#/viewer/42750

applying locally this fix compared, noticed a double speed in loading 3D tiles in same conditions.
Locally we have 2 proxies that loads slowly, but it took:

  • 1.2 minutes without this fix
  • 30 seconds with this fix.

To load all the 3D meshes. In production it already takes, with the proxy, something like 30 seconds, so we may encounter some greater improvements.

I wasn't able to replicate the same effect including the URL in useCORS, for some reason setting it, it fails, but with this fix, it looks to correctly load the tiles.

I think this is a performance improvement we need to take into account. We may change this bahavior to allow an autoDetectCORS in layers too.

@offtherailz offtherailz linked an issue Jul 11, 2024 that may be closed by this pull request
6 tasks
@offtherailz offtherailz self-assigned this Jul 11, 2024
@offtherailz offtherailz marked this pull request as draft July 11, 2024 10:45
@tdipisa
Copy link
Member

tdipisa commented Oct 7, 2024

@allyoucanmap @offtherailz I think this can be closed in favor of #10526. Isn't it?

@tdipisa tdipisa closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoDetectCORS support for cesium missing
2 participants