Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Quill editor with Draftjs editor in Dashboard's Text widget #9627

Closed
6 tasks
dsuren1 opened this issue Oct 19, 2023 · 3 comments · Fixed by #9680, #9696 or #9724
Closed
6 tasks

Replace Quill editor with Draftjs editor in Dashboard's Text widget #9627

dsuren1 opened this issue Oct 19, 2023 · 3 comments · Fixed by #9680, #9696 or #9724

Comments

@dsuren1
Copy link
Contributor

dsuren1 commented Oct 19, 2023

Description

As part of enhancement to MS in replacing quill editor across the application. We would like to replace Quill editor used in Dashboard Text widget with Draftjs in this issue

Acceptance criteria

  • Replace quill editor with Draftjs editor in Dashboard Text widget (Note: Refer also Mapview implementation of text editor with Draftjs)
  • With embedded toolbar options enabled additionally
  • Allow fontFamilies to be configurable just like in Geostory plugin

Screenshot (Expected)

Screenshot 2023-10-19 at 2 57 06 PM

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information

@dsuren1 dsuren1 added enhancement Dashboard Tasks related to dashboard Widgets labels Oct 19, 2023
@giohappy giohappy assigned mumairr and unassigned giohappy Oct 23, 2023
@mumairr
Copy link
Contributor

mumairr commented Oct 24, 2023

@dsuren1 a quick question regarding the update, I can see draft-js has been archived this February and won't receive any future updates.
On the other hand, react-quill is updated around the same time but still active and most probably recieve updates as well.
Any specific reason to upgrade to draftjs from quill? for the pdf thing, I tested it out on already integrated quill and works fine.

Please guide if i am missing something important. Thanks

@dsuren1
Copy link
Contributor Author

dsuren1 commented Oct 25, 2023

@mumairr
The decision mainly comes from maintaining a single editor across the application, as most of the parts have been replaced already.

@mumairr
Copy link
Contributor

mumairr commented Oct 25, 2023

@dsuren1 makes sense. Thanks for the explanation

@tdipisa tdipisa added this to the 2024.01.00 milestone Oct 30, 2023
mumairr added a commit to mumairr/MapStore2 that referenced this issue Nov 2, 2023
@ElenaGallo ElenaGallo self-assigned this Nov 7, 2023
mumairr added a commit to mumairr/MapStore2 that referenced this issue Nov 10, 2023
…eplace-Quill-editor-with-Draftjs-editor-in-Dashboard-Text-widget
allyoucanmap added a commit that referenced this issue Nov 21, 2023
@ElenaGallo ElenaGallo added Accepted BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch and removed Accepted labels Nov 21, 2023
mumairr added a commit to mumairr/MapStore2 that referenced this issue Nov 22, 2023
@allyoucanmap allyoucanmap removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment