Fix SpringEnvironmentAwareGeoToolsHttpClientFactory registration #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix SpringEnvironmentAwareGeoToolsHttpClientFactory registration as the default `HTTPClient` factory using the `Class` object as value instead of the qualified class name when doing `Hints.putSystemDefault( Hints.HTTP_CLIENT_FACTORY, <factory>)` in `GeoToolsStaticContextInitializer`. It doesn't work with the class name after changes upstream.
groldan
force-pushed
the
fix/gt_http_client
branch
from
d11c75d to
ba733cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
SpringEnvironmentAwareGeoToolsHttpClientFactoryregistration as the defaultHTTPClientfactory using theClassobject as value instead of the qualified class name when doingHints.putSystemDefault( Hints.HTTP_CLIENT_FACTORY, <factory>)inGeoToolsStaticContextInitializer.It doesn't work with the class name after changes upstream.
Fixes #460