Remove unused catalog-service microservice and client #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groldan
added
build
The catalog service has been out of commission for a long time now, becoming dead code. The idea is still sound but the complexity of WebFlux makes it a maintenance nightmare. Plus, with Java 21's virtual threads, it will be possible to write a non WebFlux implementation with almost the same benefits, except maybe for the reactive back-pressure support.
groldan
force-pushed
the
remove_unsued_catalog_microservice
branch
from
23cabb9 to
42db253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The catalog service has been out of commission for a long time now, becoming dead code.
The idea is still sound but the complexity of WebFlux makes it a maintenance nightmare. Plus, with Java 21's virtual threads, it will be possible to write a non WebFlux implementation with almost the same benefits, except maybe for the reactive back-pressure support.