Skip to content
This repository has been archived by the owner on Apr 2, 2022. It is now read-only.

ci #4

Merged
merged 1 commit into from
Jan 20, 2022
Merged

ci #4

merged 1 commit into from
Jan 20, 2022

Conversation

michaelkirk
Copy link
Member

No description provided.

@michaelkirk michaelkirk force-pushed the mkirk/ci branch 2 times, most recently from 1bc04db to 4d1e1c9 Compare January 20, 2022 19:16
@michaelkirk
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jan 20, 2022
@bors
Try #4:
65fec9a
@michaelkirk
Copy link
Member Author

PTAL @lnicola

@bors
Copy link
Contributor

bors bot commented Jan 20, 2022

try

Build succeeded:

@lnicola
Copy link
Member

lnicola commented Jan 20, 2022 •
edited
Loading

Looks good, but I'd skip cargo-all-features. It's not necessary right now (there are no optional features), and it's not sustainable when going over 3 or 4 optional features.

@michaelkirk
Copy link
Member Author

I'd skip cargo-all-features. It's not necessary right now

whooooops thanks @lnicola. I've fixed this.

bors r=lnicola

@bors
Copy link
Contributor

bors bot commented Jan 20, 2022

Build succeeded:

@bors bors bot merged commit d3423be into master Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lnicola lnicola lnicola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelkirk @lnicola