This repository has been archived by the owner on Apr 2, 2022. It is now read-only.
Allow checks on rings and polygons to support permutes #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
reviewed
Feb 28, 2021
| @@ -173,8 +190,11 @@ impl TestRunner { | |||
|
|
|||
| for entry in GENERAL_TEST_XML.find(&filename_filter)? { | |||
| let file = match entry { | |||
| DirEntry::Dir(_) => { debug_assert!(false, "unexpectedly found dir.xml"); continue } | |||
| DirEntry::File(file) => file | |||
| DirEntry::Dir(_) => { | |||
There was a problem hiding this comment.
whoops, sorry for not cargo fmt before my last commit.
michaelkirk
approved these changes
Feb 28, 2021
There was a problem hiding this comment.
LGTM - thanks @rmanoka!
I haven't got CI up yet, but I verified these tests pass for me locally against georust/geo#629
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for convex hull:
Now, both centroid and conv. hull checks pass.