This repository has been archived by the owner on Apr 2, 2022. It is now read-only.
JTS TestRunner which supports most Centroid and ConvexHull cases. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per your advice I've put this in a separate crate so as not to pull in MB of test data into the geo repo. If you feel good about the approach, I'd be happy to move it to georust and set up CI and whatnot. My hope is that ultimately we'll have geo's CI run these tests. |
Centroid currently fails some test against master, but I will address this in an upcoming PR to geo. Plus we skip a couple of tests because we don't yet have a way to handle collections of "POINT EMPTY". The ConvexHull cases currently fail, at least some of which is because geo always returns a Polygon for ConvexHull, whereas JTS might return other geometry types
michaelkirk
force-pushed
the
mkirk/mvp
branch
from
2170a3c to
72ae48a
Compare
michaelkirk
commented
Feb 20, 2021
|
|
||
| #[test] | ||
| // several of the ConvexHull tests are currently failing | ||
| #[ignore] |
There was a problem hiding this comment.
run this ignored test to see the failing convex hull cases.
|
Very nice work @michaelkirk ; thanks! I'll check out the convex hull and try to understand what's going on. It would indeed be good to move this to georust and link to geo CI. |
|
I'm going to merge this and update my Centroid PR to reference this. I'm also going to add a README with general instructions on how to add support for new operations. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centroid currently fails some test against master, but the ones that run pass based on the current branch patch (being upstreamed here georust/geo#629).
We still skip a couple of Centroid tests because we don't yet have a way to handle
GEOMETRYCOLLECTION(POINT EMPTY), see: georust/wkt#61Some ConvexHull tests are also failing, but I haven't looked into these failures at all, except to notice that at least some of the failures are because, whereas geo always returns a convex hull polygon, JTS actually will return other types.
/cc @rmanoka