Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

take self for unary union, for coherence with the other methods #26

Merged
merged 1 commit into from
Mar 18, 2019
Merged

take self for unary union, for coherence with the other methods #26

merged 1 commit into from
Mar 18, 2019

Conversation

antoine-de
Copy link
Contributor

No description provided.

@mthh
Copy link
Member

mthh commented Mar 17, 2019 •
edited
Loading

If I'm not mistaken UnaryUnion works notably on geometrycollections. Maybe we should also expose a function that makes it possible to create a geometrycollection from a Vec of GGeom ?
I was talking about documentation earlier because I think in the end the type of Geometry on which applying UnaryUnion could be specified (but I know that I am the main responsible for this lack of doc !)

@mthh mthh merged commit 4302f03 into georust:master Mar 18, 2019
@mthh
Copy link
Member

mthh commented Mar 18, 2019

It's probably better to open new issues and discuss them if needed than discuss them here (so I opened #27 and #28). My bad, it's merged now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthh mthh mthh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoine-de @mthh