Trait-based geometry types (no cost abstractions!) WIP. #85
Conversation
| type ItemType: LineStringTrait<T>; | ||
| type Iter: Iterator<Item=Self::ItemType>; | ||
|
|
||
| fn rings(&self) -> Self::Iter; |
There was a problem hiding this comment.
shouldn't a polygon have one outer ring and optional inner rings?
There was a problem hiding this comment.
Was going to discuss that eventually, so I guess we could do it now. For now, I'm just going to assume the first item in this iterator is the outer ring and following items are inner rings. We could probably migrate this to:
fn outer_ring(&self) -> Self::ItemType;
fn inner_rings(&self) -> Self::Iter {
// Default is no inner rings
std::iter::empty()
}Unless someone has a better idea for this.
frewsxcv
force-pushed
the
no-cost-abstractions
branch
from
43105b8 to
2b330b9
Compare
frewsxcv
force-pushed
the
no-cost-abstractions
branch
from
16c0c0b to
6efd5df
Compare
|
@frewsxcv any progress on this? if not, any way we can help move this forward? |
|
I'm trying to make these changes more incremental with other PRs, for example #151 I did hit a roadblock with this and I remember needing access to streaming iterators, which aren't a thing in Rust (yet). This is pretty out-of-date and stale at this point, so I'm going to close it. |
#67