Fix Contains edge cases for EMPTY geometries
#1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add new tests cases from jts@6a9af07059671bdc6e62542c9739137ab53fd4d8
michaelkirk
force-pushed
the
mkirk/fix-contains-for-empty
branch
from
d04f5c3
to
6b7874b
Compare
always using the (typically more correct Relate.is_contains) AFAIK there are no remaining correctness issues, but their has been a long tail of bugs with anything not using the (slower) Relate trait.
lnicola
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.And add new tests cases from jts@6a9af07059671bdc6e62542c9739137ab53fd4d8