Add DensifyGeodesic trait
#1208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
requested changes
Aug 12, 2024
|
@michaelkirk thanks for your review! I have added proposed changes |
|
I think you'll need to run cargo fmt, otherwise LGTM I'll leave it open for a couple days before merging in case anyone else wants to weigh in. |
|
I've just realised that there is already the following method: Do we still need this another implementation? |
|
Darn it. I'm sorry for not realizing this earlier. This seems related to #1181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.This PR adds
DensifyGeodesictrait that follows logic similar toDensifyHaversine. However, the trait is only implemented forT = f64as underlying Geodesic traits are implemented only for this type.