Added test and error handling #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav274
requested changes
Mar 26, 2021
| @@ -0,0 +1,78 @@ | |||
| absl-py==0.10.0 | |||
|
|
||
| # Run linter (checks code style) | ||
| pip install -r requirements.txt | ||
| flake8 --select E,F src/ test/ --exclude src/filters,src/parser/evaql |
There was a problem hiding this comment.
We don't have src/filters src/parser/evaql. So you can remove these
| create_video_from_frames(frames._batch, video_name) | ||
| return jsonify({"name": video_name}) | ||
|
|
||
| #name = video_name + ".mp4" |
| print("calling create video") | ||
| video_name = generate_video_name(RequestFrames.request_id) | ||
| create_video_from_frames(frames._batch, video_name) | ||
| return jsonify({"name": video_name}) |
There was a problem hiding this comment.
Is this only sending back the video name to the UI? How will the streaming happen?
There was a problem hiding this comment.
That's what I see from the original demo file in the demo folder. There's a send file and a send name so I think maybe send file does the file sending?
|
Did you test it with eva and eva_ui? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.