Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New backend for Oracle SQL #84

Merged
merged 4 commits into from
Jan 12, 2024
Merged

New backend for Oracle SQL #84

merged 4 commits into from
Jan 12, 2024

Conversation

totycro
Copy link
Contributor

@totycro totycro commented Dec 18, 2023

This is a recreation of an earlier PR under a different GitHub user. Original text:

For the implementation of the “OGC API – Features – Part 3: Filtering” in the Pygeoapi Oracle Provider, I expanded the geofilter to include support for Oracle. The Oracle backend also supports the use of bind variables.

Since the unit tests failed, I adapted the SQLAlchemy test.

@totycro totycro changed the title New backend for Oracle SQ New backend for Oracle SQL Dec 18, 2023
Copy link
Member

@tomkralidis tomkralidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requests (mostly source code headers). Overall the PR fits the pygeofilter architecture, so +1 from me following the updates.

pygeofilter/backends/oraclesql/__init__.py Outdated Show resolved Hide resolved
pygeofilter/backends/oraclesql/evaluate.py Show resolved Hide resolved
pygeofilter/backends/oraclesql/evaluate.py Show resolved Hide resolved
tests/backends/oraclesql/__init__.py Outdated Show resolved Hide resolved
tests/backends/oraclesql/test_evaluate.py Outdated Show resolved Hide resolved
tests/backends/sqlalchemy/test_evaluate.py Outdated Show resolved Hide resolved
@tomkralidis
Copy link
Member

FYI this PR also needs to be rebased to current main branch.

@constantinius constantinius merged commit 06254fc into geopython:main Jan 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants