Use same format handling in collection coverage as elsewhere #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This now fixes the issue that the `Accept` header wasn't considered for format selection. This adds netcdf as a known mime type in order to be able to test this, but also for actual clients to use. Note that if we want to allow other mime types such as `application/x-grib2`, we also have to add them to `FORMAT_TYPES`. Fixes geopython#1390
totycro
deleted the
1390-consider-accept-header-in-get-collection-coverage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related Issue / Discussion
This now fixes the issue that the
Acceptheader wasn't considered for format selection.This adds netcdf as a known mime type in order to be able to test this, but also for actual clients to use.
Note that if we want to allow other mime types such as
application/x-grib2, we also have to add them toFORMAT_TYPES.Fixes #1390
Contributions and Licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)