-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logfile rotation and configurable log format #1411
Conversation
docs/source/configuration.rst
Outdated
logging: | ||
logfile: /path/to/pygeoapi.log # the full file path to the logfile | ||
rotation: | ||
mode: # [None|time|size] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently if the mode
is set to null
in yaml, which would correspond to python None,
this would lead to an exception because it would be detected as an unknown mode.
I think the code is fine though, and we could require here in the documentation that mode must only be time|size
. If someone doesn't want log rotation, they can just not have the whole rotation
block.
Overview
Related Issue / Discussion
fixes #1389
fixes #1388
Contributions and Licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)