-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed datamodel-code-generator from dev requirements #1370
Removed datamodel-code-generator from dev requirements #1370
Conversation
docs/source/development.rst
Outdated
@@ -23,39 +23,6 @@ To run all tests, simply run ``pytest`` in the repository. To run a specific te | |||
run ``pytest tests/test_api.py``, for example. | |||
|
|||
|
|||
CQL extension lifecycle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing this entire section? Maybe it's better for DX to remove only Model generation
and How to merge
and add a paragraph How to hack the models
, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you envision as being the content of this alternative How to hack the models
section?
In my opinion it would likely make sense if you'd still like to recommend a workflow like the autogeneration of models using datamodel-code-generator
and then some manual tweaking. But I don't see much value in it, as the models already exist and have modifications, so it seems more likely that further changes will not restart from scratch - in which case, it seems to me that How to hack the models is not so different from how to develop pygeoapi as a whole.
But maybe I'm missing the point 😅 ?
@francbartoli can I ask for more clarification on what would be the way to move this forward? I'm not really sure what I would replace the deleted docs content with. On the other hand I'd like to move on with the work needed for #1360 and this PR is a blocker for that |
@ricardogsilva I would consider relevant to keep where this model applies and it is limited to only |
This PR removes
datamodel-code-generator
from dev requirements, following the discussion from #1367Related Issue / Discussion
Contributions and Licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)