Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed datamodel-code-generator from dev requirements #1370

Conversation

ricardogsilva
Copy link
Member

This PR removes datamodel-code-generator from dev requirements, following the discussion from #1367

Related Issue / Discussion

Contributions and Licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution.
  • I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

@ricardogsilva
Copy link
Member Author

@francbartoli

@francbartoli francbartoli self-requested a review October 6, 2023 10:21
@@ -23,39 +23,6 @@ To run all tests, simply run ``pytest`` in the repository. To run a specific te
run ``pytest tests/test_api.py``, for example.


CQL extension lifecycle
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing this entire section? Maybe it's better for DX to remove only Model generation and How to merge and add a paragraph How to hack the models, what do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you envision as being the content of this alternative How to hack the models section?

In my opinion it would likely make sense if you'd still like to recommend a workflow like the autogeneration of models using datamodel-code-generator and then some manual tweaking. But I don't see much value in it, as the models already exist and have modifications, so it seems more likely that further changes will not restart from scratch - in which case, it seems to me that How to hack the models is not so different from how to develop pygeoapi as a whole.

But maybe I'm missing the point 😅 ?

@ricardogsilva
Copy link
Member Author

@francbartoli can I ask for more clarification on what would be the way to move this forward? I'm not really sure what I would replace the deleted docs content with.

On the other hand I'd like to move on with the work needed for #1360 and this PR is a blocker for that

@francbartoli
Copy link
Contributor

@ricardogsilva I would consider relevant to keep where this model applies and it is limited to only CQL-JSON schema for the ES provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants