Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix OGC API coverages subset and datetime not forwarded #967

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

fmigneault
Copy link
Contributor

Fixes needed for OGC TB-20 TIEs.

Some parameters are not forwarded to the coverage endpoint, causing requests to be refused by servers that consider the subset to be too large to return reasonably.

owslib/ogcapi/coverages.py Outdated Show resolved Hide resolved
owslib/ogcapi/coverages.py Outdated Show resolved Hide resolved
@geographika
Copy link
Contributor

@fmigneault @tomkralidis - the failing test is due to making an external request in the offline testing. Adding the decorator @pytest.mark.online to test_ogcapi_build_url should fix this:

def test_ogcapi_build_url(path, expected):

It looks like creating any OGC API class will make an HTTP directly on __init__ - I think this differs from WMS/WFS where the class can be created and then HTTP requests made with a different call.

response = http_get(self.url, headers=self.headers, auth=self.auth).json()

@tomkralidis
Copy link
Member

@fmigneault @tomkralidis - the failing test is due to making an external request in the offline testing. Adding the decorator @pytest.mark.online to test_ogcapi_build_url should fix this:

def test_ogcapi_build_url(path, expected):

+1

It looks like creating any OGC API class will make an HTTP directly on __init__ - I think this differs from WMS/WFS where the class can be created and then HTTP requests made with a different call.

response = http_get(self.url, headers=self.headers, auth=self.auth).json()

Not sure. WMS support always does a GetCapabilities on init.

@fmigneault
Copy link
Contributor Author

I've added more tests (all passed) for the various kw updates related to OGC API coverages.
Failing tests are unrelated to this PR (records and csw tests).

@@ -21,6 +21,7 @@ tags
tester.py
tags
.idea/
.run/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove it, but this is the new location that JetBrains IDE favor to store configurations instead of .idea/, so they might be introduced by someone unintentionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants