Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add iconScale extended metadata in KML #711

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Conversation

oterral
Copy link
Contributor

@oterral oterral commented Dec 7, 2023

How to

if you use the last version of react-spatial with OL < 6.7 you should use the function readFeatures(kmlString, null, true); to avoid scaling back the Icon to a relative 32px size.

This fix is here temporarly it will be removed after next minor version deployment.

Others

  • It's not a hack or at least an unauthorized hack :).
  • The images added are optimized.
  • Everything in ticket description has been fixed.
  • The author of the MR has made its own review before assigning the reviewer.
  • The title means something for a human being and follows the conventional commits specification.
  • The title contains [WIP] if it's necessary.
  • Labels applied. if it's a release? a hotfix?
  • Tests added.

Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-spatial ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 8:57am

@oterral oterral merged commit 1b8f2f8 into master Dec 7, 2023
3 checks passed
@oterral oterral deleted the olivier/fixkml branch December 7, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant