Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dask 2025.1.0 compatibility #324

Merged
merged 16 commits into from
Jan 19, 2025

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Jan 11, 2025

This updates dask-geopandas to be compatible with the next release of
dask, which moves dask-expr into dask.dataframe.

I've dropped support for all older versions of dask. Only new versions,
based on dask-expr / with query planning, are supported.

dask currently supports Python>=3.10, so I've bumped that requirement as well.

Closes #324

This updates dask-geopandas to be compatible with the next release of
dask, which moves dask-expr into dask.dataframe.

I've dropped support for all older versions of dask. Only new versions,
based on dask-expr / with query planning, are supported.
@TomAugspurger
Copy link
Contributor Author

OK, the upstream-dev tests passed at https://github.com/geopandas/dask-geopandas/actions/runs/12734777705/job/35492743562?pr=324. The rest are failing because that's using a new dask.dataframe.api module that's present on main but not yet released. IMO, we can plan to release dask-geopandas the same day as dask 2025.1.0, and maintain compatibility without a ton of compatibility code.

@martinfleis
Copy link
Member

I am fine with the approach. I suppose we can merge this and cut a release, given task 2025.1 was released yesterday? Might be worth getting #322 in as well prior the release.

@TomAugspurger TomAugspurger marked this pull request as ready for review January 18, 2025 23:05
@TomAugspurger
Copy link
Contributor Author

TomAugspurger commented Jan 18, 2025

Just merged conda-forge/dask-core-feedstock#229. Will make a PR for conda-forge/dask-feedstock next (conda-forge/dask-feedstock#284).

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tom!

@TomAugspurger
Copy link
Contributor Author

Removed the compatibility handling around use_nullable_dtypes. We just do the same as upstream dask now.

Planning to merge this and #322 before cutting a release.

@TomAugspurger TomAugspurger merged commit 105bfd6 into geopandas:main Jan 19, 2025
13 checks passed
@TomAugspurger TomAugspurger deleted the tom/upstream-compat branch January 19, 2025 20:19
@TomAugspurger
Copy link
Contributor Author

I'm not sure why the GitHub Action had a failure at https://github.com/geopandas/dask-geopandas/actions/runs/12857203343/job/35844805603, but version 0.4.3 was uploaded to PyPI: https://pypi.org/project/dask-geopandas/0.4.3/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants