-
-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for integration tests #8625
base: main
Are you sure you want to change the base?
Conversation
|
elastic doc on this option: |
// the thesaurus already exists. This will clean up and there will not be a problem on the next run. | ||
// This is typically only an issue if you are running the test locally - on the build server it gets a | ||
// new, clean, filesystem so there isn't a problem. | ||
var uploadedThesauras = geonetworkDataDirectory.resolveWebResource( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not use var
as probably we have to backport this to 4.2.x
, please change to use Path
and add the import.
This does the following:
Set the integration test's elastic so it will NOT give
low disk watermark
error messages and refuse to start if your disk is >90% full.core/
services/
Set
services
so that it runs on a single JVM. This was because elastic is shared between all the different test cases - some tests were modifying the data at the same time (cf Formatter / Use portal filter #8263), causing inconsistencies as to the uuid of metadata recordid=100
.services/
. However, the slowdown was very small on my local computer. This is something to keep an eye on.KeywordsApiTest#testImportOntologyToSkos
uploaded a file - this would be written (by the ThesaurusManager) to the file system (WEB-INF). On the next run, the test would give an error saying the thesaurus already exisitsThis is problematic on development machines with low disk available (>90% full), and quite difficult to remedy.
I suspect that this hasn't been noticed because the build server;
Checklist
main
branch, backports managed with labelREADME.md
filespom.xml
dependency management. Update build documentation with intended library use and library tutorials or documentation