Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove link from admin-guide to schematron details as inappropriate #8121

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

jodygarnett
Copy link
Contributor

These are two different audiences. When deploying admin guide in isolation this produces a broken link.

If configuration of validation levels requires customization then the activity should move to the customization section.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Thanks to GeoCat Live for the opportunity to assist with documentation.

These are two different audiences. When deploying admin guide in isolation this produces a broken link.

If configuration of validation levels requires customization then the activity should move to the customization section.
@jodygarnett
Copy link
Contributor Author

Okay I am prepared for some discussion here; but I do wish to see the documentation gradually improve. The present mixing of concerns makes geonetwork appear harder then necessary.

It is okay if customization is needed to adjust validation levels, and if expert assistance to customize schematron rules - but present it as such.

If not administrators determine that "geonetwork is too hard to administer" limiting our target audience. Editing schematron files is customization (expert customization) and not something to expect of an administrator.

Copy link

sonarcloud bot commented May 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jodygarnett to me it makes sense to remove this.

I would remove also the entry INSPIRE rules (TG v1.3), that rules are no longer provided.

@jodygarnett
Copy link
Contributor Author

Do you mean remove the entire page or just the link :)

@jodygarnett jodygarnett merged commit 8814532 into main Jun 1, 2024
11 checks passed
@jodygarnett jodygarnett deleted the jodygarnett-managing-standards branch June 1, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants