Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address two-character literal doc translation glitch #7687

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Address two-character literal doc translation glitch #7687

merged 2 commits into from
Feb 13, 2024

Conversation

jodygarnett
Copy link
Contributor

@jodygarnett jodygarnett commented Feb 1, 2024 •
edited by archaeogeek
Loading

A glitch #7666 due to documentation conversion was identified by @davidblasby and @archaeogeek.

The following files need to be addressed:

  • csw-configuration.md one occurrence found
  • inspire-configuration.md 2 occurrences found
  • authentication-mode.md 32 occurrences found
  • creating-group.d one occurrence found
  • adding-static-pages.md 7 occurrences found
  • configuring-search-fields.d 2 occurrences found
  • creating-custom-editor.d 23 occurrences found
  • enrichview.md one occurrence found
  • loadview.md one occurrence found
  • configuring-database.md one occurrence found
  • installing-from-war-file.md one occurrence found
  • map-print-setup.d one occurrence found
  • version-4.0.2.md 8 occurrences found
  • tutorials/introduction/deployment/index.md 3 occurrences found
  • harvesting-simpleurl.d one occurrence found
  • managing-privileges.md one occurrence found
  • life-cycle.md one occurrence

@jodygarnett jodygarnett mentioned this pull request Feb 1, 2024
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

archaeogeek added a commit to AstunTechnology/custom-geonetwork that referenced this pull request Feb 5, 2024
@archaeogeek
Addressing docs translation glitch geonetwork#7687- fixes adding-stat…
2c9bfc8 
…ic-pages and configuring-search-fields
@archaeogeek archaeogeek mentioned this pull request Feb 5, 2024
Merged
10 tasks
@archaeogeek
Copy link
Contributor

@jodygarnett which index.md has the problem in it?

archaeogeek added a commit to AstunTechnology/custom-geonetwork that referenced this pull request Feb 5, 2024
@archaeogeek
Addressing docs translation glitch geonetwork#7687- fixes creating-cu…
fcf7f9c 
…stom-editor
jodygarnett pushed a commit that referenced this pull request Feb 6, 2024
Addressing docs translation glitch #7687- fixes adding-static-pages a…
9cefa22 
…nd configuring-search-fields (#7696)

* Addressing docs translation glitch #7687- fixes adding-static-pages and configuring-search-fields
* Addressing docs translation glitch #7687- fixes creating-custom-editor
geonetworkbuild pushed a commit that referenced this pull request Feb 6, 2024
@archaeogeek @github-actions
Addressing docs translation glitch #7687- fixes adding-static-pages a…
5289d49 
…nd configuring-search-fields
geonetworkbuild pushed a commit that referenced this pull request Feb 6, 2024
@archaeogeek @github-actions
Addressing docs translation glitch #7687- fixes creating-custom-editor
006b8be
@jodygarnett
Copy link
Contributor Author

@jodygarnett which index.md has the problem in it?

It is tutorials/introduction/deployment/index.md

jodygarnett pushed a commit that referenced this pull request Feb 6, 2024
@archaeogeek @jodygarnett
Addressing docs translation glitch #7687- fixes adding-static-pages a…
28fb29f 
…nd configuring-search-fields
jodygarnett pushed a commit that referenced this pull request Feb 6, 2024
@archaeogeek @jodygarnett
Addressing docs translation glitch #7687- fixes creating-custom-editor
23f1d1c
@archaeogeek
Copy link
Contributor

Sorry, Git non-expert here! I've created this commit AstunTechnology@1b795a8 to address three new files, but I can't seem to get the pull request right- making it against main shows me the 2 previous commits as well, and making it against docs-glitch seems to bring in lots of changes that we don't want. How do I just bring the new commit in?

@jodygarnett
Copy link
Contributor Author

jodygarnett commented Feb 7, 2024 •
edited
Loading

Sorry, Git non-expert here! I've created this commit AstunTechnology@1b795a8 to address three new files, but I can't seem to get the pull request right- making it against main shows me the 2 previous commits as well, and making it against docs-glitch seems to bring in lots of changes that we don't want. How do I just bring the new commit in?

I understand, let me try and cherry pick the commit over to here.

To be effective you need start from this branch, not from main, and then we should be able to work on this branch together.

If you are available during the same timezone I can help on chat or jitsi

@archaeogeek
Copy link
Contributor

@jodygarnett I've created #7745 to address the remaining issues

@jodygarnett jodygarnett marked this pull request as ready for review February 13, 2024 19:10
jodygarnett
jodygarnett commented Feb 13, 2024
View reviewed changes
Copy link
Contributor Author

@jodygarnett jodygarnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging and back porting the PRs associated with this topic

@jodygarnett jodygarnett merged commit c278a8c into main Feb 13, 2024
11 checks passed
@jodygarnett jodygarnett deleted the docs-glitch branch February 13, 2024 19:11
@geonetworkbuild geonetworkbuild mentioned this pull request Feb 13, 2024
Merged
@jodygarnett jodygarnett restored the docs-glitch branch February 13, 2024 19:19
@juanluisrp juanluisrp mentioned this pull request Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@archaeogeek archaeogeek

@MichelGabriel MichelGabriel

Labels
backport 4.2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jodygarnett @archaeogeek @MichelGabriel