-
-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elasticssearch 8 upgrade #7599
Elasticssearch 8 upgrade #7599
Conversation
…ad of Java High Level REST Client
…l feature, not used. Related to #4912
…RROR: Elasticsearch exited unexpectedly, with exit code 143
…ed overview field
…n hits. A request may return no hits but can be used to check number of hits. In such case we should avoid using hits.hits.size and use hits.total.value to get number of match.
…s, clear the Xlink cache automatically before indexing and remove non-implemented code to retrieve metadata with XLink (not required anymore)
Hi, Thanks for the extensive work. Do you know what is the timeline for this change to be merged? And is that going to be in 4.4.3 or be part of another major version (4.6)? |
Quality Gate failedFailed conditions |
ping @josegar74 @fxprunayre for the question above 🙂 thanks! |
@jahow I think the plan is to merge that in I know also that probably there is no clear agreement on which branch is the stable one, but my point on that. |
Ok so as I understand this will be part of the upcoming 4.4.3 version. Thanks for the clarification! |
Error was Validation Failed: 1: script or doc is missing. Related to ES8 migration #7599
@josegar74 on a fresh
the index is not starting because of I found some stuff on stackoverflow about that but is it a known issue ? |
@fgravin I think by default ES 8 uses https, you need either to disable it or update the configuration for GeoNetwork to use https, it will require to install the certs in the JVM. I always use an external instance using Docker with all that stuff configured. For development, probably the best is to disable the setting |
Yes I've modified |
Error was Validation Failed: 1: script or doc is missing. Related to ES8 migration #7599
@davidblasby here is the PR that updated es.version. I came here to ask that the following be updated:
But reading above @fgravin is already aware. |
I do not see an issue to open with respect to this pull request, since this was merged two weeks ago I do not feel comfortable asking for a revert. With that in mind here is a small PR updating es/ instructions #7805 |
Main change is update to Elasticsearch 8. Aligned with compose in main repo geonetwork/core-geonetwork#7817 Follow up geonetwork/core-geonetwork#7599.
Main change is update to Elasticsearch 8. Aligned with compose in main repo geonetwork/core-geonetwork#7817 Follow up geonetwork/core-geonetwork#7599.
Main change is update to Elasticsearch 8. Aligned with compose in main repo geonetwork/core-geonetwork#7817 Follow up geonetwork/core-geonetwork#7599.
Follow up of #7599 `result.hits().hits().size()` returns number of records in response, not total hits matching search. `numberOfRecordsMatched` is wrong. ``` <csw:SearchResults numberOfRecordsMatched="10" numbe ```
Follow up of #7599 `result.hits().hits().size()` returns number of records in response, not total hits matching search. `numberOfRecordsMatched` is wrong. ``` <csw:SearchResults numberOfRecordsMatched="10" numbe ```
This pull request updates Elasticsearch client to version 8, replacing the Elasticsearch Java High Level REST Client, that is no longer supported, with the new Elasticsearch Java API Client.
The code supports Elasticsearch servers 7.15+ and 8+
Several Sonarlint improvements have been applied.
As part of the work, two changes related to identified code to be updated have been done. These changes require to be backported to version 4.2.x:
The
Admin console
>Tools
>Clear XLink cache
option has been removed, as was not implemented in GeoNetwork 4.x, and the process is executed automatically on metadata indexing to simplify the management of the XLink cache.The feature to retrieve related resources from the index, that was not used, have been removed.
Checklist
main
branch, backports managed with labelREADME.md
filespom.xml
dependency management. Update build documentation with intended library use and library tutorials or documentationFunded by BRGM
Funded by EEA