Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the export path #168

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix the export path #168

merged 1 commit into from
Oct 1, 2024

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Oct 1, 2024 •
edited
Loading

QGIS API cannot save the file if the path contains '~' for home directory.

This PR expand the user path to get an absolute one.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Binder 👈 Launch a Binder on branch brichet/jupytergis/fix_export_path

@brichet brichet added the bug Something isn't working label Oct 1, 2024
martinRenou
martinRenou approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 967fae1 into geojupyter:main Oct 1, 2024
11 of 12 checks passed
@brichet brichet deleted the fix_export_path branch October 4, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brichet @martinRenou