Switch to OpenLayers for the main view #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gjmooney
force-pushed
the
open_layers_support
branch
from
0470388
to
90751d1
Compare
gjmooney
force-pushed
the
open_layers_support
branch
from
407c1a0
to
a9744c2
Compare
martinRenou
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Thank you for this! It's quite a huge PR 🚀
- I think we're missing an
@import url('ol/ol.css');in our CSS, maybe inpackages/base/style/base.css. OpenLayers is not styled properly. - The brush icon in the toolbar is mal-positioned I believe. Because for now this button only makes sense for Geotiff layers (or does it not?). I would put it in the properties panel for the geotiff layer when clicking on the layer.
- When selecting the geotiff layer in
geotiff.jGISfile, the properties panel seems confused about the form being generated and show lots of errors - the
pmtiles-vector.jGISexample does not show the vector pmtiles layer anymore - I would remove the
console.logcalls here and there (mostly inpackages/base/src/dialogs/colorExpressionDialog.tsx)
ui-tests/tests/notebook.spec.ts-snapshots/light-Notebook-ipynb-cell-2-linux.png
Outdated
Show resolved
Hide resolved
martinRenou
requested changes
Sep 3, 2024
I'm not sure how to handle this, I tried hiding the color field, but the errors still show up. |
Yes, let's handle this in a follow-up PR with a new fancy color widget |
|
bot please update snapshots!! pretty please |
martinRenou
changed the title
martinRenou
approved these changes
Sep 4, 2024
brichet
added a commit
to brichet/jupytergis
that referenced
this pull request
Sep 6, 2024
martinRenou
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Remove the lat/long from options and use the extent instead * update python test * Use extent in open layer (after merging #112) * Update examples with extent option * Fix python test * Set the extent as optionnal, use the lat/long by default * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Super rough draft of adding an OpenLayers viewer and fancy color things.
Some notes, and things for future PRs:
Issues: