Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add separate nightly deal.II master Docker script with clang #5838

Merged
merged 1 commit into from
Jun 11, 2024
Merged

add separate nightly deal.II master Docker script with clang #5838

merged 1 commit into from
Jun 11, 2024

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Jun 6, 2024 •
edited
Loading

  • add a clang based Docker image to be used for clang compilation and clang-tidy in the future
  • add a workflow to build this image
    FYI @gassmoeller

gassmoeller
gassmoeller reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, just some comments

contrib/docker/nightly-tester/Dockerfile Outdated Show resolved Hide resolved
contrib/docker/nightly-tester/local.cfg Outdated Show resolved Hide resolved
contrib/docker/nightly-tester/Dockerfile Outdated Show resolved Hide resolved
@tjhei
Copy link
Member Author

tjhei commented Jun 7, 2024

I can confirm that clang-tidy is working with this disk image. How do we proceed?

gassmoeller
gassmoeller approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. We can merge this and then proceed with a second nightly github actions build for the container.

@tjhei tjhei force-pushed the clang-tidy branch 2 times, most recently from 9e7bc62 to d05d1ac Compare June 10, 2024 17:48
gassmoeller
gassmoeller reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@gassmoeller gassmoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there, some comments.

.github/workflows/build_dealii_master_clang.yml Outdated Show resolved Hide resolved
.github/workflows/build_dealii_master_clang.yml Outdated Show resolved Hide resolved
.github/workflows/clang-tidy.yml Outdated Show resolved Hide resolved
.github/workflows/clang-tidy.yml Outdated Show resolved Hide resolved
contrib/docker/tester-clang/Dockerfile Outdated Show resolved Hide resolved
contrib/docker/tester-clang/build.sh Outdated Show resolved Hide resolved
@tjhei
add separate nightly deal.II master script with clang
42c4b9b 
- now use clang instead
- install packages using apt except deal.II

Plan: use this to run clang-tidy in the future.
@tjhei
Copy link
Member Author

tjhei commented Jun 10, 2024

updated (and I removed the clang-tidy workflow)

@gassmoeller gassmoeller merged commit a45e2a8 into geodynamics:main Jun 11, 2024
8 checks passed
@tjhei tjhei deleted the clang-tidy branch June 11, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bangerth bangerth bangerth left review comments

@gassmoeller gassmoeller gassmoeller approved these changes

Assignees
No one assigned
Labels
ready to merge ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjhei @bangerth @gassmoeller