Update geocoder-php/common-http to version 4.5 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package php-http/message-factory is abandoned, you should avoid using it. Use psr/http-factory instead.
|
Sorry for not providing the composer.lock too ☮️ |
Hussam92
commented
Sep 24, 2023
| @@ -44,4 +44,4 @@ | |||
| "test": "vendor/bin/phpunit", | |||
| "test-ci": "vendor/bin/phpunit --coverage-text --coverage-clover=build/coverage.xml" | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Not really sure what happend here. I used the GitHub UI to apply these changes. No IDE involved
There was a problem hiding this comment.
probably the end of line is always added in the GitHub UI
|
Is there any update on this? I also get
|
synsas
reviewed
Nov 18, 2024
Because this isn't meant to be merged. I just notified the maintainers about necessary version update. I didn't dive into the code to verify if everything works when this update is applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package php-http/message-factory is abandoned, you should avoid using it. Use psr/http-factory instead.