Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs for geoarrow::io module & GeometryArray FFI fix #959

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Improve docs for geoarrow::io module & GeometryArray FFI fix #959

merged 4 commits into from
Dec 20, 2024

Conversation

kylebarron
Copy link
Member

@kylebarron kylebarron commented Dec 20, 2024 •
edited
Loading

Change list

  • Simplify implementation of RecordBatchReader wrapper.
  • Deny missing documentation in geoarrow::io.
  • Implement writing a RectArray to a WKBArray
  • Update FromWKB to impl for GeometryArray.
  • Use the GeometryArray impl for the dyn NativeArray impl.
  • Fix GeometryArray FFI. We hadn't been correctly exporting the underlying GeometryCollection array.

@kylebarron kylebarron changed the title Improve docs for geoarrow::io Improve docs for geoarrow::io module Dec 20, 2024
@kylebarron kylebarron marked this pull request as ready for review December 20, 2024 22:35
@kylebarron kylebarron enabled auto-merge (squash) December 20, 2024 22:35
@kylebarron kylebarron changed the title Improve docs for geoarrow::io module Improve docs for geoarrow::io module & GeometryArray FFI fix Dec 20, 2024
@kylebarron kylebarron merged commit 681b6a4 into main Dec 20, 2024
21 checks passed
@kylebarron kylebarron deleted the kyle/io-docs branch December 20, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kylebarron