handle push_null
in the unknown geometry builder
#894
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding nulls is tricky. We often want to use this builder as a generic builder for data
from unknown sources, which then gets downcasted to an array of a specific type.
In a large majority of the time, this builder will have only data of a single type, which
can then get downcasted to a simple array of a single geometry type and dimension. But in
order for this process to be easy, we want the nulls to be assigned to the same array type
as the actual data.
When there's a valid geometry pushed before the null, we can add the null to an existing
non-null array type, but if there are no valid geometries yet, we don't know which array to
push the null to. This
deferred_nulls
is the number of initial null values that haven'tyet been written to an array, because we don't know which array to write them to.