GeoParquet reader revamp #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
One thing before I dive too deeply into tweaking the request flow - this doesn't happen to cover HEAD request elimination or the metadata size guess stuff, right? (the latter point, every file in the overture maps dataset undershoots by about 320kB - well, it's either that or there's something immediately preceding the FileMetaData region that's always read) |
No it doesn't |
That might be the PageIndex |
Closed
kylebarron
pushed a commit
that referenced
this pull request
Aug 23, 2024
If it's ok, I'd be stoked to get a v0.3.0 release of **geoarrow** — some of my **stac-geoparquet** is getting close to being release-able. Here's a checklist of things that have been mentioned as part of a v0.3 (including #628 (comment) and https://github.com/geoarrow/geoarrow-rs/milestone/3): - #660 is done ✅ - Some (but not all) of the doc updates are done in #696, and I've got a tracking issue for the rest in #689 - "Broader support for 3d geometries" isn't done as far as I know, but I haven't really been touching that at all yet - #539 is a Python thing, not a Rust crate thing As a part of this release PR I've updated our deps when possible (`sqlx` will require code change to support an update so I haven't done that one).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difficulty here is that you need to be able to know the output schema at the start of the iterator, before accessing any data
Also, we should look more closely into the
parquetArrowReaderBuilder. That has a lot of functionality to cover both sync and async readers. Can we put all the geospatial functionality in aGeoParquetReader<ArrowReaderBuilder<T>>, and then do the same batch transforms for each geoparquet batch for both async and sync readers?