Add CI to build features in isolation #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
force-pushed
the
isolated-features
branch
from
58cca41 to
0cd75f1
Compare
gadomski
changed the title
gadomski
force-pushed
the
isolated-features
branch
2 times, most recently
from
1963e86 to
f18fd24
Compare
gadomski
force-pushed
the
isolated-features
branch
from
f18fd24 to
3445dbf
Compare
Can't be in `async` because it's used by sync code. Also fix some tests that require some features.
kylebarron
approved these changes
May 27, 2024
| @@ -9,18 +9,23 @@ | |||
| //! use geoarrow::io::parquet::ParquetReaderOptions; | |||
| //! use std::fs::File; | |||
| //! | |||
| //! # #[cfg(feature = "parquet_compression")] | |||
| //! # { | |||
There was a problem hiding this comment.
I'm curious, why do you have a { here? Is that needed?
There was a problem hiding this comment.
It's to feature-gate the whole test in the a block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If downstreams want to just depend on a single feature, we need to make sure we can build w/ just that feature enabled ... e.g. as of this writing,
parquetimplicitly depends onasyncbut isn't configured as such inCargo.toml.We can't test w/o installing GDAL and friends because
gdalis a dev dependency, so we just build.