Ewkb support for WKBArray #254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
reviewed
Nov 17, 2023
kylebarron
reviewed
Nov 17, 2023
| geozero::wkb::Wkb(buf.to_vec()).to_geo().unwrap() | ||
| match value.flavor { | ||
| WKBFlavor::ISO => geozero::wkb::Wkb(buf.to_vec()).to_geo().unwrap(), | ||
| WKBFlavor::EWKB => geozero::wkb::Ewkb(buf.to_vec()).to_geo().unwrap(), |
There was a problem hiding this comment.
This is a very small subset of the wkb parsing in this crate. The majority happens when casting a wkb array to a concretely-typed geometry array. That happens with our own WKB parsing (see crate::io::wkb iirc). As a precursor to ewkb support, we need to support parsing ewkb geometries with those functions, or else ewkb will still crash on the vast majority of operations
There was a problem hiding this comment.
This exceed my knowledge. I don't know the binary format difference between wkb flavors yet. Now I mainly use WKBArray instead of concretely-typed array. Maybe we can merge this pr but still keep the issue open? I will learn them, it'll nice if you have time to create pr to fully support ewkb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.