Refactor codebase to use geoarrow_schema crate
#1016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
changed the title
geoarrow_schema crate
kylebarron
added a commit
that referenced
this pull request
Apr 3, 2025
…trait (#1015) ### Change list - Add new `geoarrow_schema` crate - Move `CoordType`, `Dimension`, `Crs`, `Edges`, `Metadata`, to new crate. - Add tests for metadata serialization and deserialization - Add new geometry-type-specific structs: BoxType, GeometryCollectionType, GeometryType, LineStringType, MultiLineStringType, MultiPointType, MultiPolygonType, PointType, PolygonType, WkbType, WktType - Implement the upstream [`ExtensionType`](https://docs.rs/arrow-schema/latest/arrow_schema/extension/trait.ExtensionType.html) trait for each of these new structs. Closes #987 cc @paleolimbot Will probably leave for future PRs integrating this into existing `geoarrow` code because it'll require changing our current use of `NativeType` (see #1016 draft)
kylebarron
changed the title
geoarrow_schema crategeoarrow_schema crate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to
geoarrow_schemacrs_typeandcrs_valuetoCrsCrsTypeandEdgesCopyTryFrom<&Field> for MetadataPointType::to_fieldand similar for all geometry typesGeometrytype not containing GeometryCollectionChange list
NativeTypeenum variants to hold the new types from geoarrow-schema crate, plus implementation of upstream ExtensionType trait #1015. This means that theNativeTypenow stores GeoArrow metadata as well, not just coordinate type and dimension.PointArray::data_typeis aPointType, not aNativeType::Point.geoarrow_schema. We don't currently re-export types fromgeoarrow_schemathroughgeoarrowso that it's clear what pieces of code do or do not actually need the fullgeoarrowcrate.Post #1015